Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Generate sap-ui-custom-dbg.js for self-contained build #234

Merged
merged 1 commit into from
Apr 2, 2019
Merged

[FIX] Generate sap-ui-custom-dbg.js for self-contained build #234

merged 1 commit into from
Apr 2, 2019

Conversation

devtomtom
Copy link
Member

@devtomtom devtomtom commented Apr 2, 2019 •
edited by RandomByte
Loading

Fixes #161

matz3
matz3 reviewed Apr 2, 2019
View reviewed changes
Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the commit message is missing the [FIX] category

@devtomtom devtomtom changed the title Generate sap-ui-custom-dbg.js for self-contained build [FIX] Generate sap-ui-custom-dbg.js for self-contained build Apr 2, 2019
@coveralls
Copy link

coveralls commented Apr 2, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 84.849% when pulling 5b13014 on add-sap-ui-custom-dbg-bundle into 3bf0f56 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 84.694% when pulling e0fed91 on add-sap-ui-custom-dbg-bundle into 3bf0f56 on master.

@devtomtom devtomtom force-pushed the add-sap-ui-custom-dbg-bundle branch from e0fed91 to 5b13014 Compare April 2, 2019 10:54
@devtomtom devtomtom merged commit d769d98 into master Apr 2, 2019
@devtomtom devtomtom deleted the add-sap-ui-custom-dbg-bundle branch April 2, 2019 15:20
devtomtom added a commit that referenced this pull request Jun 17, 2019
@devtomtom
[FIX] Generate sap-ui-custom-dbg.js for self-contained build (#234)
957e213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matz3 matz3 matz3 approved these changes

@RandomByte RandomByte Awaiting requested review from RandomByte

@codeworrior codeworrior Awaiting requested review from codeworrior

@stopcoder stopcoder Awaiting requested review from stopcoder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

self-contained build using in debug mode not possible
3 participants
@devtomtom @coveralls @matz3